fix: incorrect negated assertion for rule existence check #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnu
commented
Oct 8, 2020
| const matcherTest = (received, expected) => { | ||
| const matcherTest = (received, expected, isNot) => { | ||
| // when negating, assert on existence of the style, rather than the value | ||
| if (isNot && expected === undefined) { |
There was a problem hiding this comment.
Changed the strictness of the "falsey expected" condition. I believe the intention was to check for the existence of the second parameter to toHaveStyleRule, so "=== undefined" is better here. I can relax this, if there's concern around it being a breaking change.
|
@probablyup This and the associated issue has been open since 2020. Do you think this change makes sense? |
quantizor
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #344